Comments on: WTF? http://blog.xcski.com/2008/01/25/wtf-2 Everything I used to bore people on newsgroups and mailing lists with, now in one inconvenient place. Tue, 02 Dec 2008 00:25:17 +0000 http://wordpress.org/?v=2.6.5 By: Paul Tomblin http://blog.xcski.com/2008/01/25/wtf-2#comment-74232 Paul Tomblin Sat, 26 Jan 2008 00:31:22 +0000 http://blog.xcski.com/2008/01/25/wtf-2#comment-74232 Yeah, but up until this guy got fired in Christmas 2006, I sat about 5 cubes away from him and he could have said "Is there a reason why your clone method doesn't preserve externalID", said "I need you to fix your clone method so it preserves externalID", or written up a PCR at any time. Yeah, but up until this guy got fired in Christmas 2006, I sat about 5 cubes away from him and he could have said “Is there a reason why your clone method doesn’t preserve externalID”, said “I need you to fix your clone method so it preserves externalID”, or written up a PCR at any time.

]]> By: Tina Marie http://blog.xcski.com/2008/01/25/wtf-2#comment-74231 Tina Marie Sat, 26 Jan 2008 00:28:20 +0000 http://blog.xcski.com/2008/01/25/wtf-2#comment-74231 >If any of my code is wrong, fix it. Please. I don't agree with this. Sometimes there's a reason I did something one way, and if you don't really know the context, you could break it. An example from a few years ago: We had a base singleton class, and there were some quirks in the constructor. One of our senior developers got sick of it and fixed them, and as a side effect made the class un-thread-safe. He didn't tell anyone he'd made the change, and it got into the field that way and required a hotfix when it was found. If he'd walked down the hall and asked the original writer, they'd have told him why it was the way it was. >If any of my code is wrong, fix it. Please.

I don’t agree with this. Sometimes there’s a reason I did something one way, and if you don’t really know the context, you could break it.

An example from a few years ago: We had a base singleton class, and there were some quirks in the constructor. One of our senior developers got sick of it and fixed them, and as a side effect made the class un-thread-safe. He didn’t tell anyone he’d made the change, and it got into the field that way and required a hotfix when it was found. If he’d walked down the hall and asked the original writer, they’d have told him why it was the way it was.

]]> By: Kris Johnson http://blog.xcski.com/2008/01/25/wtf-2#comment-74157 Kris Johnson Fri, 25 Jan 2008 15:31:25 +0000 http://blog.xcski.com/2008/01/25/wtf-2#comment-74157 Yeah, I'm always amazed at programmers' unwillingness to fix or critique "someone else's code." I don't know whether to attribute it to lack of confidence, a perceived lack of authority, or just plain lack of intelligence. If any of my code is wrong, fix it. Please. Yeah, I’m always amazed at programmers’ unwillingness to fix or critique “someone else’s code.” I don’t know whether to attribute it to lack of confidence, a perceived lack of authority, or just plain lack of intelligence.

If any of my code is wrong, fix it. Please.

]]> By: Jed Davis http://blog.xcski.com/2008/01/25/wtf-2#comment-74099 Jed Davis Fri, 25 Jan 2008 04:23:11 +0000 http://blog.xcski.com/2008/01/25/wtf-2#comment-74099 // I have eaten the plums // that were in the icebox // as the playlist cone function // doesn't copy the playlist // external id which we really need There. Much better. // I have eaten the plums
// that were in the icebox
// as the playlist cone function
// doesn’t copy the playlist
// external id which we really need

There. Much better.

]]>